ci: normalize to actions/setup-python + pip, matching sibling toolboxes - #49
Merged
Conversation
Up to standards ✅🟢 Issues
|
petercorke
force-pushed
the
ci/remove-conda-micromamba
branch
from
August 3, 2026 00:32
ce01b54 to
1a65a8e
Compare
RTB, bdsim, and SMTB all use actions/setup-python + pip install .[dev]; MVTB was the only one still on mamba-org/setup-micromamba with a hand-maintained conda create-args package list. That split meant pyproject.toml's opencv-python<5.0.0 / opencv-contrib-python<5.0.0 pins were never actually exercised by CI (pip install .[dev] --no-deps --no-build-isolation skipped dependency resolution entirely), which is how CI silently started testing against opencv 5.0.0 when conda-forge's unpinned opencv package resolved there. Drop --no-deps so pip's resolver actually enforces pyproject.toml's pins, add pytest-timeout/pytest-xvfb to the dev extra (previously only present in the conda create-args list), and install the tool extra so tests/test_bin.py's IPython/pygments-dependent mvtbtool coverage still runs. Swap the conda-forge libegl install for the apt equivalent on Linux. Verified with a real pip install into an isolated venv: resolves to opencv-contrib-python 4.14.0.94 (honoring the <5.0.0 pin for real), full test suite passes (771 passed, 94 skipped). Fixes #43 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
petercorke
force-pushed
the
ci/remove-conda-micromamba
branch
from
August 3, 2026 00:39
1a65a8e to
b859069
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mamba-org/setup-micromamba+ hand-maintained condacreate-argswithactions/setup-python+ plainpip install .[dev,tool], matching RTB/bdsim/SMTB's CI setup -- MVTB was the only sibling toolbox still on conda.--no-deps --no-build-isolation: previously CI's pip install explicitly skipped dependency resolution, sopyproject.toml'sopencv-python<5.0.0/opencv-contrib-python<5.0.0pins were never actually enforced by CI -- only by real end users installing viapip. That gap is exactly how CI silently started testing OpenCV 5.0.0 once conda-forge's unpinnedopencvpackage resolved there (see opencv5 migration: dual-version (4/5) compatibility #44).pytest-timeout/pytest-xvfbto thedevextra inpyproject.toml(previously only present in the condacreate-argslist, sopip install .[dev]alone was missing what the test run actually needs).libeglinstall for the apt equivalent (libegl1 libgl1).Fixes #43
Test plan
sys.prefixchecked) with plainpip install .[dev,tool]-- resolves cleanly, honoring the<5.0.0opencv pin for real (opencv-contrib-python-4.14.0.94).