fix: use spatialgeometry's correctly-spelled _propagate_scene_tree() - #570
Open
petercorke wants to merge 2 commits into
Open
fix: use spatialgeometry's correctly-spelled _propagate_scene_tree()#570petercorke wants to merge 2 commits into
petercorke wants to merge 2 commits into
Conversation
_propogate_scene_tree() was a misspelling of "propagate" in spatialgeometry -- see jhavl/spatialgeometry#38, which adds the correctly-spelled _propagate_scene_tree() and keeps the old misspelled name as a deprecated (FutureWarning) alias. Migrate Link.py's and Robot.py's 8 call sites to the new name ahead of the old one's eventual removal. Not touching this repo's own vendored src/spatialgeometry/ snapshot -- that's separate, deliberate legacy left alone until Swift/SG work is done.
Follow-up to the previous commit here -- spatialgeometry's PR (jhavl/spatialgeometry#38) was amended before merging: instead of landing a correctly-spelled but still-private _propagate_scene_tree() only to deprecate it again immediately after, it went straight to a public update() method. _propogate_scene_tree() (the original misspelled name this repo used to call) remains available as a deprecated (FutureWarning) alias, but Link.py/Robot.py should call update() directly. Confirmed no collision with any existing RTB method: grepped the whole roboticstoolbox tree for def update( and found only unrelated local functions elsewhere (PyPlot backends, mobile/Animations.py) -- none on Robot/Link or anything in their MRO. Confirmed live: rtb.Robot.update is spatialgeometry.SceneNode.update.
petercorke
force-pushed
the
fix/propagate-typo-rename
branch
from
August 10, 2026 00:06
f34070f to
972ff0d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 142 142
Lines 13825 13827 +2
=====================================
- Misses 13825 13827 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spatialgeometry's_propogate_scene_tree()was a plain misspelling of"propagate" -- see jhavl/spatialgeometry#38.
That PR was amended before merging: rather than landing a correctly-spelled
but still-private
_propagate_scene_tree()only to deprecate it againimmediately after, it went straight to a public
update()method._propogate_scene_tree()(the original misspelled name this repo called)remains available as a deprecated (
FutureWarning) alias for back-compat,but this migrates
Link.py's andRobot.py's 8 call sites to callupdate()directly instead.Not touching this repo's own vendored
src/spatialgeometry/snapshot --that's separate, deliberate legacy left alone for now.
Test plan
whole
roboticstoolboxtree fordef update(-- only unrelated localfunctions elsewhere (PyPlot backends,
mobile/Animations.py), none onRobot/Linkor anywhere in their MROrtb.Robot.update is spatialgeometry.SceneNode.updateis
True(
Panda()) in this environment:Link.pycallsSceneGroup(scene_children=geometry)directly, which doesn't matchSceneGroup's actual constructor (initlist, notscene_children) --a separate API mismatch, nothing to do with this change. Not chased down
per your steer on
test_Robot.py's existing ~34 unrelated failures.