ext/curl: Deprecate the NTLM_WB constants#22691
Open
GrahamCampbell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcurl removed NTLM_WB support in 8.8.0, so on any current libcurl the
CURLAUTH_NTLM_WBbit is silently filtered out ofCURLOPT_HTTPAUTH/CURLOPT_PROXYAUTHmasks and theCURL_VERSION_NTLM_WBfeature bit is never set; only builds against libcurl older than 8.8.0 can still use the feature at all.This deprecates both constants with
#[\Deprecated], following theCURLOPT_BINARYTRANSFERprecedent from PHP 8.4, so code still referencing NTLM_WB is nudged to drop it. TheNTLMWBkey incurl_version()['feature_list']is kept and continues to reportfalseat runtime. This is also a first step in preparing for curl's scheduled removal of NTLM support altogether in September 2026 (https://curl.se/dev/deprecate.html); the still-functionalCURLAUTH_NTLMandCURL_VERSION_NTLMconstants are intentionally left alone.