Fix GH-22683: Reflection(Class)Constant::__toString() should not warn on NAN conversions#22694
Open
khaledalam wants to merge 2 commits into
Open
Fix GH-22683: Reflection(Class)Constant::__toString() should not warn on NAN conversions#22694khaledalam wants to merge 2 commits into
khaledalam wants to merge 2 commits into
Conversation
DanielEScherzer
requested changes
Jul 11, 2026
DanielEScherzer
left a comment
DanielEScherzer
left a comment
Member
There was a problem hiding this comment.
the implementation looks good, but can you please
- retarget this PR so that it is for PHP 8.5
- in the tests, the error handler can be removed, since warnings will show up in the output and then can be seen in the failure comparison, no need for the custom "Unexpected warning" messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-22683.
Add an IS_DOUBLE branch that formats the value with smart_str_append_double() instead.