Skip to content

run-tests: Add {TEST_NAME} placeholder storing the basename of the test file - #23472

Open
TimWolla wants to merge 1 commit into
php:masterfrom
TimWolla:run-tests-test-name-placeholder
Open

run-tests: Add {TEST_NAME} placeholder storing the basename of the test file#23472
TimWolla wants to merge 1 commit into
php:masterfrom
TimWolla:run-tests-test-name-placeholder

Conversation

@TimWolla

Copy link
Copy Markdown
Member

This makes it easier to write tests with associated temporary files in a conflict-free way without needing to copy-and-paste the filename everywhere.

…test file

This makes it easier to write tests with associated temporary files in a
conflict-free way without needing to copy-and-paste the filename everywhere.
@TimWolla
TimWolla requested a review from Girgias August 26, 2026 15:40
@TimWolla
TimWolla requested a review from bukka as a code owner August 26, 2026 15:40

@jorgsowa jorgsowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. What do you think about more clarity, i.e. TEST_FILE_BASENAME or TEST_FILE_NAME.

@TimWolla

Copy link
Copy Markdown
Member Author

What do you think about more clarity

I wanted to avoid the extra verbosity, since using the placeholder is an explicit action (it doesn't magically create an environment variable where namespacing might be desirable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants