Fix sparse set allocation size overflow - #23482
Open
crystarm wants to merge 1 commit into
Open
Conversation
LamentXU123
requested changes
Aug 27, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
This should be fixed upstream: https://github.com/dstogov/ir
Contributor
Author
|
@LamentXU123 Should I close this PR? |
Member
|
If your PR is merged upstream. Then sync the commit to this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an integer-overflow risk when calculating the allocation size for IR sparse sets.
Uses
ir_mem_calloc(size, 2 * sizeof(*set->data))so the allocator performs the checked multiplication, while preserving the existing sparse/dense memory layout.The issue was detected by static analysis: BAD_ALLOC_ARITHMETIC ir_private.h:[500:14].log