Fix wrong ACP parent module in add_webpush revert_data#134
Merged
Conversation
…ON → ACP_CLIENT_COMMUNICATION)
Copilot
AI
changed the title
[WIP] Fix ACP_BOARD_CONFIGURATION to use ACP_CLIENT_COMMUNICATION
Fix wrong ACP parent module in add_webpush revert_data
Jul 23, 2026
iMattPro
marked this pull request as ready for review
July 23, 2026 17:40
iMattPro
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert_data()inadd_webpushreferencedACP_BOARD_CONFIGURATIONas the parent module when removing the ACP entry, butupdate_data()installs it underACP_CLIENT_COMMUNICATION. This mismatch meant the module entry was never cleaned up on disable/uninstall.Change
migrations/add_webpush.php— correct themodule.removeparent fromACP_BOARD_CONFIGURATIONtoACP_CLIENT_COMMUNICATIONto match the install path: