Skip to content

Fix wrong ACP parent module in add_webpush revert_data#134

Merged
iMattPro merged 2 commits into
mainfrom
copilot/fix-acp-board-configuration
Jul 23, 2026
Merged

Fix wrong ACP parent module in add_webpush revert_data#134
iMattPro merged 2 commits into
mainfrom
copilot/fix-acp-board-configuration

Conversation

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

revert_data() in add_webpush referenced ACP_BOARD_CONFIGURATION as the parent module when removing the ACP entry, but update_data() installs it under ACP_CLIENT_COMMUNICATION. This mismatch meant the module entry was never cleaned up on disable/uninstall.

Change

  • migrations/add_webpush.php — correct the module.remove parent from ACP_BOARD_CONFIGURATION to ACP_CLIENT_COMMUNICATION to match the install path:
// Before
['module.remove', ['acp', 'ACP_BOARD_CONFIGURATION', 'ACP_WEBPUSH_EXT_SETTINGS']]

// After
['module.remove', ['acp', 'ACP_CLIENT_COMMUNICATION', 'ACP_WEBPUSH_EXT_SETTINGS']]

Copilot AI changed the title [WIP] Fix ACP_BOARD_CONFIGURATION to use ACP_CLIENT_COMMUNICATION Fix wrong ACP parent module in add_webpush revert_data Jul 23, 2026
Copilot AI requested a review from iMattPro July 23, 2026 17:39
@iMattPro
iMattPro marked this pull request as ready for review July 23, 2026 17:40
@iMattPro
iMattPro merged commit ce76fd8 into main Jul 23, 2026
33 checks passed
@iMattPro
iMattPro deleted the copilot/fix-acp-board-configuration branch July 23, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants