Track define()'d constants as exported nodes#6036
Merged
Merged
Conversation
Global constants declared with define() have the same result-cache staleness
as `const` had: a file reading a define()'d constant records a dependency on
the defining file (via the ConstFetch handling), but a define() is a function
call rather than a declaration, so it produced no exported node. Changing the
define()'s value therefore did not re-analyse the reading files.
Export define('NAME', <value>) calls with a literal name, reusing
ExportedConstantNode, so changing the value re-analyses the dependents.
Covered by a result-cache e2e test.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b84866e to
dff37cf
Compare
Collaborator
|
This pull request has been marked as ready for review. |
staabm
approved these changes
Jul 11, 2026
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6023.
Global constants declared with
define()have the same result-cache staleness that #6023 fixed forconst. A file reading adefine()'d constant records a dependency on the defining file (via theConstFetchhandling from #6023), but adefine()is a function call rather than a declaration, so it produced no exported node. The result cache re-analyses a changed file's dependents only when its exported nodes change, so changing thedefine()'s value did not re-analyse the reading files.This exports
define('NAME', <value>)calls that have a literal name, reusing theExportedConstantNodefrom #6023, so changing the value re-analyses the dependents.Reproducing the staleness
Before this change the second run keeps
consumer.phpcached and reports nothing; with it, the consumer is re-analysed and reports the return-type error, matching a cold run. Covered by theresult-cache-definee2e test.