config: reword primary lease descriptions for clarity - #23132
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the scheduling and TSO configuration files, rephrasing the description of the lease timeout to refer to the service's primary lease. Feedback suggests capitalizing "Scheduling" in the scheduling configuration file to maintain consistency with "TSO" and other occurrences in the document.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@bufferflies would you please take a look at this PR? Thanks. |
59e198c to
1df8ff1
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes update lease descriptions for the Scheduling and TSO services. The descriptions identify each service’s primary lease, use lowercase re-election terminology where applicable, and change the default timeout from 3 to 5 seconds. ChangesLease description updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@bufferflies: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Scheduling and TSO microservices use PD's DefaultLeaderLease, which is 5 seconds, not 3. Verified against tikv/pd release-8.5: pkg/mcs/utils/constant/constant.go (DefaultLeaderLease = int64(5)). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What is changed, added or deleted? (Required)
Reword the
lease\> description inscheduling-configuration-file.mdandtso-configuration-file.mdto avoid confusion with databasePRIMARY KEY` terminology.Before:
After:
Similarly for the TSO configuration file.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?
Summary by CodeRabbit