fix(build): identify cross-architecture probe by executable - #7253
Open
lastobelus wants to merge 1 commit into
Open
fix(build): identify cross-architecture probe by executable#7253lastobelus wants to merge 1 commit into
lastobelus wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Approved c8a24eb Test-only change that makes an assertion more specific by also verifying the command path. No runtime code is affected. You can customize Macroscope's approvability policy. Learn more. |
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 16, 2026
The cross-architecture Windows payload test treats any child command carrying ELECTRON_RUN_AS_NODE=1 as the packaged primary probe. LastCode local updates run from Electron and inherit that variable, so the ordinary Node self-containment check is misclassified and full local CI fails before a build can be produced. Identify the primary probe by both its packaged executable path and Electron runtime flag. This keeps the assertion scoped to its intended behavior and allows local update builds launched from LastCode. Upstream: pingdotgg#7253 Validation: - focused scripts/build-desktop-artifact.test.ts: 47 passed - exact-head full local CI passed for dfdb1d4 against eab34f9 - pre-push quick local CI passed Implemented with GPT-5.6-Sol through the Codex harness in T3 Code.
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 16, 2026
The cross-architecture Windows payload test treats any child command carrying ELECTRON_RUN_AS_NODE=1 as the packaged primary probe. LastCode local updates run from Electron and inherit that variable, so the ordinary Node self-containment check is misclassified and full local CI fails before a build can be produced. Identify the primary probe by both its packaged executable path and Electron runtime flag. This keeps the assertion scoped to its intended behavior and allows local update builds launched from LastCode. Upstream: pingdotgg#7253 Validation: - focused scripts/build-desktop-artifact.test.ts: 47 passed - exact-head full local CI passed for dfdb1d4 against eab34f9 - pre-push quick local CI passed Implemented with GPT-5.6-Sol through the Codex harness in T3 Code.
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 17, 2026
The cross-architecture Windows payload test treats any child command carrying ELECTRON_RUN_AS_NODE=1 as the packaged primary probe. LastCode local updates run from Electron and inherit that variable, so the ordinary Node self-containment check is misclassified and full local CI fails before a build can be produced. Identify the primary probe by both its packaged executable path and Electron runtime flag. This keeps the assertion scoped to its intended behavior and allows local update builds launched from LastCode. Upstream: pingdotgg#7253 Validation: - focused scripts/build-desktop-artifact.test.ts: 47 passed - exact-head full local CI passed for dfdb1d4 against eab34f9 - pre-push quick local CI passed Implemented with GPT-5.6-Sol through the Codex harness in T3 Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cross-architecture Windows payload test treats any child command carrying ELECTRON_RUN_AS_NODE=1 as the packaged primary probe. When tests are launched from Electron, that variable is inherited by the ordinary Node self-containment check, so the assertion fails even though the primary probe was correctly skipped.
Identify the primary probe by both its packaged executable path and Electron runtime flag. This keeps the assertion scoped to the behavior it intends to test and makes it independent of ambient Electron environment variables.
Downstream port: lastobelus#18
Validation: vp test run build-desktop-artifact.test.ts (46 passed).
Implemented with GPT-5.6-Sol through the Codex harness in T3 Code.