Docs: Fix broken examples links after v0/v1 restructure - #7233
Conversation
✅ Deploy Preview for pipecd-site canceled.
|
There was a problem hiding this comment.
Pull request overview
Updates v0.58 and development documentation links after examples moved into the v0/ directory.
Changes:
- Updated Kubernetes, Terraform, Cloud Run, Lambda, ECS, and deployment-chain links.
- Applied updates to both documentation versions.
- Additional stale links remain in other documentation and
examples/v0/README.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Summary |
|---|---|
docs/content/en/docs-v0.58.x/examples/_index.md |
Updated examples links to /v0/ paths; related stale references remain elsewhere. |
docs/content/en/docs-dev/examples/_index.md |
Updated examples links to /v0/ paths; related stale references remain elsewhere. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| | [analysis-by-log](https://github.com/pipe-cd/examples/tree/master/kubernetes/analysis-by-log) | Deployment pipeline with analysis stage by checking logs. | | ||
| | [analysis-with-baseline](https://github.com/pipe-cd/examples/tree/master/kubernetes/analysis-with-baseline) | Deployment pipeline with analysis stage by comparing baseline and canary. | | ||
| | [secret-management](https://github.com/pipe-cd/examples/tree/master/kubernetes/secret-management) | Demonstrate how to manage sensitive data by using [Secret Management](../user-guide/managing-application/secret-management/) feature. | | ||
| | [simple](https://github.com/pipe-cd/examples/tree/master/v0/kubernetes/simple) | Deploy plain-yaml manifests in application directory without using pipeline. | |
There was a problem hiding this comment.
@rahulshendre I confirm this is true, check out those files for follow up PRs, we need to sync other refs too
There was a problem hiding this comment.
correct, will push those fixes soon
| | [analysis-by-log](https://github.com/pipe-cd/examples/tree/master/kubernetes/analysis-by-log) | Deployment pipeline with analysis stage by checking logs. | | ||
| | [analysis-with-baseline](https://github.com/pipe-cd/examples/tree/master/kubernetes/analysis-with-baseline) | Deployment pipeline with analysis stage by comparing baseline and canary. | | ||
| | [secret-management](https://github.com/pipe-cd/examples/tree/master/kubernetes/secret-management) | Demonstrate how to manage sensitive data by using [Secret Management](../user-guide/managing-application/secret-management/) feature. | | ||
| | [simple](https://github.com/pipe-cd/examples/tree/master/v0/kubernetes/simple) | Deploy plain-yaml manifests in application directory without using pipeline. | |
|
ref - #7173 (review) PTAL @khanhtc1202 @armistcxy |
|
@rahulshendre seems like you forgot to sign off commit 😄 |
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
2887a24 to
75fb857
Compare
my bad 😅 |
There was a problem hiding this comment.
LGTM
I have confirmed that those new links work (through Netlify)
Next step: fix these refs from copilot suggestion: https://github.com/pipe-cd/pipecd/pull/7233/changes#r3844507232
cc @rahulshendre
|
Thank you for contributing to PipeCD, @rahulshendre! The changes in this pull request will be part of the upcoming release! |
What this PR does:
After splitting examples into v0/ and v1/ directories, the examples docs pages still linked to the old paths, which now 404s.
Why we need it:
Fixes old path
Which issue(s) this PR fixes:
Follow up of #7173
Does this PR introduce a user-facing change?: