callback args hardening.#3902
Merged
Merged
Conversation
camdecoster
approved these changes
Jul 17, 2026
camdecoster
left a comment
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
This seems fine, but I think @KoolADE85 should give it look before you merge.
|
KoolADE85
approved these changes
Jul 20, 2026
KoolADE85
left a comment
KoolADE85
left a comment
Contributor
There was a problem hiding this comment.
I tested this locally, and it's working well for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix background callbacks trusting the client-supplied
job/oldJob/cancelJobandcacheKeyquery parameters verbatim, which let an unauthenticated client terminate an arbitrary process (withDiskcacheManager, by sending its PID) or read and delete arbitrary result-cache entries. ThecacheKey/jobhandles are now HMAC-signed by the server and bound to a per-page-load token, so forged or replayed values are rejected. Handles stay opaque to the renderer, so no app or callback code changes are required.