Fix - Prevent TypeError in CheckboxesField::regex() when stored value is invalid JSON

[RomainLvr]

Changes description

Checklist

Please check if your PR fulfills the following specifications:

• Tests for the changes have been added
• Docs have been added/updated

Description

• It fixes !44948
• Here is a brief description of what this PR does

When rendering the plugin_formcreator_solved_issues dashboard widget, a TypeError is thrown:

preg_grep(): Argument #2 ($array) must be of type array, null given

This happens when a form answer contains a checkbox field with a regex visibility condition, and the stored JSON value is corrupted or invalid. json_decode() returns null on invalid input, leaving $this->value = null, which then causes preg_grep() to throw.

A secondary bug was also found in LdapselectField::regex(), which incorrectly used preg_grep() on a plain string value instead of preg_match().

Changes

• CheckboxesField::deserializeValue(): add is_array() guard after json_decode() so $this->value always ends up as an array, even when the stored data is malformed. This mirrors the existing pattern in ActorField.
• LdapselectField::regex(): replace preg_grep() with preg_match(), consistent with RadiosField which holds a single string value.
• tests/CheckboxesField.php: add testRegex() covering valid match, no match, invalid JSON, and JSON-null cases.

[stonebuzz]

LGTM

[Rom1-B]

regex() behavior changed (preg_grep → preg_match), but tests/3-unit/GlpiPlugin/Formcreator/Field/LdapSelectField.php has no test for regex() at all, before or after this fix. Can you add a case mirroring providerRegex in CheckboxesField.php?

[Rom1-B]

providerRegex covers null, '', invalid JSON string, and the JSON null literal, but not other valid-JSON-non-array values (e.g. '"a string"', '42', '{"a":1}') that also hit the is_array($decoded) ? $decoded : [] branch. Not required given the generic array check, but worth one more case for full branch coverage.

[stonebuzz]

providerRegex doesn't cover valid-JSON non-array values (e.g. '"a string"', '42', '{"a":1}') that also reach the is_array($decoded) ? $decoded : [] fallback branch.

Suggested change

	yield 'null-decoded json value does not throw and returns false' => [
	'value' => 'null',
	'pattern' => '/foo/',
	'expected' => false,
	];
	yield 'null-decoded json value does not throw and returns false' => [
	'value' => 'null',
	'pattern' => '/foo/',
	'expected' => false,
	];
	yield 'valid json non-array value does not throw and returns false' => [
	'value' => '"a string"',
	'pattern' => '/foo/',
	'expected' => false,
	];