Tests: Add support for endpoints with same path but different method#4382
Open
osulzhenko wants to merge 8 commits into
Open
Tests: Add support for endpoints with same path but different method#4382osulzhenko wants to merge 8 commits into
osulzhenko wants to merge 8 commits into
Conversation
marki1an
requested changes
Feb 23, 2026
marki1an
left a comment
marki1an
left a comment
Collaborator
There was a problem hiding this comment.
Also would be good to see tests for:
AMP_GET("GET /openrtb2/amp")
AMP_POST("POST /openrtb2/amp")
| return Future.failedFuture(exception); | ||
| } else if (exception instanceof PreBidException) { | ||
| unknownAccountLogger.warn(accountErrorMessage(exception.getMessage(), httpRequest), 100); | ||
| unknownAccountLogger.warn(accountErrorMessage(exception.getMessage(), httpRequest), logSamplingRate); |
| import org.prebid.server.functional.service.PrebidServerException | ||
| import org.prebid.server.functional.service.PrebidServerService | ||
| import org.prebid.server.functional.util.PBSUtils | ||
| import spock.lang.IgnoreRest |
| flushMetrics(pbsServiceWithMultipleModules) | ||
|
|
||
| and: "Save base active account" | ||
| def account = new Account(uuid: bidRequest.getAccountId(), status: ACTIVE) |
Collaborator
There was a problem hiding this comment.
Why do we need to add a new Account with status active if we have a default account in the config?
Looks strange
Collaborator
Author
There was a problem hiding this comment.
We need this because of the 'settings.enforce-valid-account': 'true' setting. If set to false, it ignores invalid accounts and won't emit errors for unknownAccountLogger
Collaborator
There was a problem hiding this comment.
Then we can remove defaultAccountConfigSettings
| flushMetrics(pbsServiceWithMultipleModules) | ||
|
|
||
| and: "Save account without modules config" | ||
| def account = new Account(uuid: bidRequest.getAccountId(), status: ACTIVE) |
Collaborator
There was a problem hiding this comment.
Same here, weird behaviour.
Test describe says that it shouldn't call any module without an account config
Collaborator
There was a problem hiding this comment.
Please change the test name
| when: "PBS processes auction request" | ||
| pbsServiceWithMultipleModule.sendAuctionRequest(bidRequest) | ||
|
|
||
| then: "PBS response should include trace information about called modules" |
| assert !response.ext?.warnings | ||
| assert !response.ext?.errors | ||
|
|
||
| and: "PBS log should contain message" |
marki1an
requested changes
Feb 26, 2026
| flushMetrics(pbsServiceWithMultipleModules) | ||
|
|
||
| and: "Save account without modules config" | ||
| def account = new Account(uuid: bidRequest.getAccountId(), status: ACTIVE) |
Collaborator
There was a problem hiding this comment.
Please change the test name
| flushMetrics(pbsServiceWithMultipleModules) | ||
|
|
||
| and: "Save base active account" | ||
| def account = new Account(uuid: bidRequest.getAccountId(), status: ACTIVE) |
Collaborator
There was a problem hiding this comment.
Then we can remove defaultAccountConfigSettings
CTMBNara
force-pushed
the
extend-endpoints
branch
from
June 29, 2026 14:11
6c5dc09 to
4acbf87
Compare
osulzhenko
force-pushed
the
functional-tests/extend-endpoints
branch
from
July 24, 2026 10:39
c244d6a to
fe300c1
Compare
# Conflicts: # src/main/java/org/prebid/server/json/deserializer/ExecutionPlanEndpointsConfigDeserializer.java # src/main/java/org/prebid/server/model/Endpoint.java # src/test/groovy/org/prebid/server/functional/testcontainers/container/PrebidServerContainer.groovy # src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/AbTestingModuleSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/GeneralModuleSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/ModuleBaseSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/analyticstag/AnalyticsTagsModuleSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/pbortb2blocking/PbOrtb2BlockingSpec.groovy
osulzhenko
force-pushed
the
functional-tests/extend-endpoints
branch
from
July 24, 2026 10:41
fe300c1 to
d2fc71e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check