Modules: Rename open-source modules and align hook suffixes#4427
Merged
Conversation
marki1an
previously requested changes
Mar 18, 2026
| ORTB2_BLOCKING("pb-ortb2-blocking"), | ||
| PB_REQUEST_CORRECTION('pb-request-correction'), | ||
| OPTABLE_TARGETING('optable-targeting'), | ||
| OPTABLE_TARGETING('pb-optable-targeting'), |
Collaborator
There was a problem hiding this comment.
What about renaming OPTABLE_TARGETING to PB_OPTABLE_TARGETING and others?
And1sS
requested changes
Mar 25, 2026
| PB_ORTB2_BLOCKING("pb-ortb2-blocking"), | ||
| PB_REQUEST_CORRECTION('pb-request-correction'), | ||
| OPTABLE_TARGETING('pb-optable-targeting'), | ||
| PB_OPTABLE_TARGETING('pb-optable-targeting'), |
Collaborator
There was a problem hiding this comment.
Why did you add pb prefix to non-prebid module?
osulzhenko
force-pushed
the
rename-open-source-modules
branch
from
March 26, 2026 10:07
67cc019 to
a4d80cd
Compare
And1sS
previously approved these changes
Apr 25, 2026
CTMBNara
previously approved these changes
Jul 4, 2026
osulzhenko
force-pushed
the
rename-open-source-modules
branch
2 times, most recently
from
July 10, 2026 15:20
a534e04 to
18a238e
Compare
osulzhenko
force-pushed
the
rename-open-source-modules
branch
from
July 22, 2026 10:33
18a238e to
5f011e3
Compare
Lightwood13
previously approved these changes
Jul 23, 2026
And1sS
previously approved these changes
Jul 23, 2026
And1sS
dismissed
marki1an’s stale review
July 23, 2026 12:35
Rename of optable to pb-optable doesn't make sense as it is not prebid module.
CTMBNara
previously approved these changes
Jul 23, 2026
Lightwood13
approved these changes
Jul 23, 2026
And1sS
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check