Cut all 30 Hacking Legends cards - #8
Merged
Merged
Conversation
Generated with gpt-image-2 via `pnpm hacking portraits`. Committed so the Series Two art can be reviewed on GitHub before the card faces are cut. Sizes match the Series One convention (~1.5MB per portrait). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Runs the full pipeline over the Series Two roster: 54 enhance passes on top of the 6 faces the sample run already produced, then publish at 500x745. All 30 cards now carry `front`/`back` paths, so /hacking-legends shows the finished deck instead of placeholders. Also fixes an idempotency bug in `writeArtPaths()`. It cleared `current` immediately after inserting, so pre-existing `front`/`back` lines sitting after `status:` no longer matched the drop-check and survived alongside the newly inserted pair. Cards 1, 5 and 12 -- the three from the sample run -- came out with duplicate keys. Republishing is now safe to repeat. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ThreatCrush Security Scan1 finding(s) MEDIUM: 1
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the Hacking Legends deck. Two commits: the 30 portraits, then the 60 published card faces.
What ran
pnpm hacking allover the full roster, ongpt-image-2:/hacking-legendsnow shows the finished deck instead of placeholders.Portraits are committed this time
assets/portraits/hacking-legends/held nothing but a.gitkeepon master, because generated art lands in the gitignoredassets/portraits-art/. That made the set impossible to review on GitHub, so all 30 portraits are committed here (47MB, in line with Series One's 95MB at ~2MB each).Anything in that directory now wins over regeneration. To redraw a portrait, delete that file and re-run
pnpm hacking portraits.Bug fix: publish was not idempotent
writeArtPaths()clearedcurrentimmediately after inserting, so pre-existingfront/backlines sitting afterstatus:stopped matching the drop-check and survived alongside the newly inserted pair. Cards 1, 5 and 12 — the three from the sample run — came out with duplicate object keys. Cards with no prior art were unaffected, which is why the sample run looked fine.Fixed by keeping
currentset and tracking inserts in a separateSet. Verified by re-runningpublishtwice: 30 fronts and 30 backs both times.Checks
pnpm hacking validate— passed, 30 on the roster. The 20 warnings are pre-existingdraft/candidatecopy status, not art.pnpm build— clean, all 8 routes.Still your call
hacking.tsare my editorial ratings, not sourced facts.gpt-image-2draws a plausible period-accurate figure rather than a photographic match. Closer faces would mean feeding reference images to the edit endpoint.draft/candidateon copy.🤖 Generated with Claude Code