Skip to content

fix: catch OverflowError in naturalsize() for very large integers #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koteshyelamati wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix: catch OverflowError in naturalsize() for very large integers #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/humanize/filesize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@ def naturalsize(
suffix = suffixes["decimal"]

base = 1024 if (gnu or binary) else 1000
bytes_ = float(value)
try:
bytes_ = float(value)
except (ValueError, OverflowError) as exc:
raise ValueError(
f"naturalsize() argument must be a number, not {type(value).__name__!r}"
) from exc
abs_bytes = abs(bytes_)

if abs_bytes == 1 and not gnu:
Expand Down