gh-142740: Fix ABC registration for SetProxy in multiprocessing.managers - #142741
Open
hyongtao-code wants to merge 7 commits into
Open
gh-142740: Fix ABC registration for SetProxy in multiprocessing.managers#142741hyongtao-code wants to merge 7 commits into
hyongtao-code wants to merge 7 commits into
Conversation
Register _BaseSetProxy as MutableSet instead of MutableMapping. SetProxy implements set semantics and does not implement the mapping protocol, so the previous ABC registration caused incorrect type classification. Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
Member
|
This change should have a news entry because it affects users. If this change is correct, I also think we need to add a test to ensure we don’t break it in the future. |
Contributor
Author
|
Hi, thanks for the review. I’ve added both a news entry and a test case. I believe this case demonstrates that the code change's logic is correct. |
hyongtao-code
marked this pull request as draft
December 18, 2025 12:48
hyongtao-code
marked this pull request as ready for review
December 18, 2025 13:49
|
This PR is stale because it has been open for 30 days with no activity. |
aisk
reviewed
Aug 28, 2026
aisk
reviewed
Aug 28, 2026
Co-authored-by: An Long <aisk@users.noreply.github.com>
Removed no need tests for mutable set from the multiprocessing test suite.
aisk
approved these changes
Aug 28, 2026
aisk
added
3.14
Documentation build overview
365 files changed ·
|
aisk
added
needs backport to 3.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register _BaseSetProxy as MutableSet instead of MutableMapping. SetProxy implements set semantics and does not implement the mapping protocol, so the previous ABC registration caused incorrect type classification.