gh-153563 feat: add unicode_memeq() to compare either directly or SSE2 vector#153564
Open
rajat315315 wants to merge 2 commits into
Open
gh-153563 feat: add unicode_memeq() to compare either directly or SSE2 vector#153564rajat315315 wants to merge 2 commits into
rajat315315 wants to merge 2 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fixes #153563
Proposed Changes
Objects/stringlib/eq.hto implement a static inline memory comparisonunicode_memeqthat optimizes checks for string lengths up to 32 bytes.memcmpfunction call insideunicode_eqfor these short string sizes.__x86_64__, etc.) to guarantee portability on ARM, WebAssembly, and older x86 machines.Verification & Testing
Rebuilt CPython on Linux x86_64 with GCC 15 and ran the standard regression test suite. All tests passed successfully:
Benchmarks (Mean Latency of String Equality Comparison)
Measured Python-level comparison times using different pointers (recreated string objects) with identical hashes to isolate the
unicode_eqpath:For keys of length 2, 8, and 12 characters (which represent the vast majority of Python identifiers), this optimization provides a 16% to 35% speedup at the Python runtime level, directly accelerating attribute lookups and dictionary throughput.
unicode_eqfor short string comparisons by bypassingmemcmpoverhead #153563