gh-153568: Skip parser memo lookups that cannot match#153571
Open
pablogsal wants to merge 1 commit into
Open
Conversation
pablogsal
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
lysnikolaou,
ncoghlan and
warsaw
as code owners
Each token now carries a small filter of the rule types present in its memo list, so the common case of a miss no longer walks the list.
pablogsal
force-pushed
the
gh-153568-memo-filter
branch
from
f6d8abf to
a638dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most memoization probes miss, and each one walked a linked list through arena memory to find out. A per-token filter of the memoized rule types answers definite misses with a single bit test.
Benchmark (parsing 8 of the largest stdlib files, 1.3 MB, 20 times per run with
_PyParser_ASTFromString— parser only, no AST-to-Python conversion; pyperf, interleaved runs):