gh-153581: Fix create_autospec producing an uncallable mock for functools.partialmethod#153582
Open
claudiubelu wants to merge 1 commit into
Open
Conversation
… functools.partialmethod functools.partialmethod objects have no __call__ of their own (they are non-data descriptors, only callable once resolved through attribute access), so create_autospec's _callable() check treated them as non-callable and forced Klass = NonCallableMagicMock. Autospeccing such an attribute directly (e.g.: mock.patch.object(cls, name, autospec=True)) therefore produced a mock that raised TypeError on every call, even though the real attribute is perfectly callable. _callable() now judges callability from the wrapped function (partialmethod.func) instead. _get_signature_object() gained a matching branch that computes the partialmethod's effective signature, self dropped, the partialmethod's own pre-bound positional/keyword arguments applied, so the resulting mock also enforces the correct call signature rather than accepting anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
functools.partialmethodobjects have no__call__of their own (they are non-data descriptors, only callable once resolved through attribute access), socreate_autospec's_callable()check treated them as non-callable and forcedKlass = NonCallableMagicMock. Autospeccing such an attribute directly (e.g.:mock.patch.object(cls, name, autospec=True)) therefore produced a mock that raisedTypeErroron every call, even though the real attribute is perfectly callable._callable()now judges callability from the wrapped function (partialmethod.func) instead._get_signature_object()gained a matching branch that computes thepartialmethod's effective signature, self dropped, thepartialmethod's own pre-bound positional / keyword arguments applied, so the resulting mock also enforces the correct call signature rather than accepting anything.mock.patch(..., autospec=True)on afunctools.partialmethodattribute produces a completely uncallable mock #153581