gh-153569: Add tokenizer source and cursor primitives#153587
Open
pablogsal wants to merge 1 commit into
Open
Conversation
pablogsal
requested review from
a team,
AA-Turner,
emmatyping,
ericsnowcurrently,
erlend-aasland,
itamaro and
lysnikolaou
as code owners
pablogsal
force-pushed
the
gh-153569-tokenizer-offset-api
branch
from
bce3caa to
2682fe5
Compare
pablogsal
changed the title
pablogsal
force-pushed
the
gh-153569-tokenizer-offset-api
branch
from
2682fe5 to
1bf43aa
Compare
maurycy
reviewed
Jul 11, 2026
Comment on lines
+237
to
+239
| while (current < lineno) { | ||
| const char *newline = memchr( | ||
| source->bytes + start, '\n', source->len - start); |
Contributor
There was a problem hiding this comment.
@pablogsal Do you think this could use a helper? Similar new line search logic seems to be in four places:
cpython/Parser/tokenizer/source.c
Line 218 in 1bf43aa
cpython/Parser/tokenizer/source.c
Line 269 in 1bf43aa
cpython/Parser/tokenizer/cursor.c
Line 15 in 1bf43aa
cpython/Parser/tokenizer/cursor.c
Line 49 in 1bf43aa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the decoded source store, offset spans, and an offset-only cursor as the foundation for moving tokenizer state away from buffer pointers.