Skip to content

[3.15] gh-154352: Fix killing a worker process in regrtest on OpenBSD (GH-154353) #154360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 1 commit into from
Jul 21, 2026
+6 −3
Merged

[3.15] gh-154352: Fix killing a worker process in regrtest on OpenBSD (GH-154353) #154360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Lib/test/libregrtest/run_workers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,12 @@ def _kill(self) -> None:

use_killpg = USE_PROCESS_GROUP
if use_killpg:
parent_sid = os.getsid(0)
sid = os.getsid(popen.pid)
use_killpg = (sid != parent_sid)
try:
use_killpg = (os.getsid(popen.pid) != os.getsid(0))
except PermissionError:
# On OpenBSD getsid() is only allowed for a process in the
# same session, so the failure means that it is not.
use_killpg = True

if use_killpg:
what = f"{self} process group"
Expand Down
Loading