gh-154894: Reject duplicate unicode path extra fields in zipfile - #156641
Open
litvak-daniil wants to merge 1 commit into
Open
gh-154894: Reject duplicate unicode path extra fields in zipfile#156641litvak-daniil wants to merge 1 commit into
litvak-daniil wants to merge 1 commit into
Conversation
|
All commit authors signed the Contributor License Agreement. |
A member may carry the Unicode Path extra field (0x7075) more than once, and ZIP parsers disagree on which duplicate wins, so the encoded filename is ambiguous rather than merely redundant. zipfile silently took the last one. Raise BadZipFile instead.
litvak-daniil
force-pushed
the
fix/gh-154894-duplicate-unicode-path
branch
from
August 30, 2026 10:10
4fee4db to
782d701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A member may carry the Unicode Path extra field (
0x7075) more than once.zipfilesilently takes the last one, and other ZIP parsers make differentchoices, so the decoded filename is ambiguous rather than merely redundant —
which is the differential described in the issue.
This raises
BadZipFilewhen a second0x7075field is seen for the samemember. The reproducer from the issue now fails to open instead of returning
['last.txt'].test_zipfile,test_zipimportandtest_importlibpass.Please note this is a behaviour change: archives that previously opened will
now be rejected. The issue is filed as "consider rejecting" and I did not find
a maintainer decision on it, so please treat this as a proposal. I am happy to
close it, or to emit a warning and keep the current last-one-wins behaviour
instead, if either is preferred.