Mark math.log parameters as positional-only#16042
Merged
AlexWaygood merged 1 commit intoJul 19, 2026
Merged
Conversation
`math.log` is a C function that accepts no keyword arguments; at runtime `math.log(x=8)` and `math.log(8, base=2)` both raise `TypeError: math.log() takes no keyword arguments`. The stub omits the trailing `/`, so type checkers wrongly accept those keyword forms. Every sibling in the same module is already positional-only — isqrt, ldexp, lgamma, log10, log1p, log2, modf all end with `, /` — and `cmath.log` is also `(z, base=..., /)`. `math.log` is the lone exception. Add `, /` (a positional-only parameter may still carry a default).
AlexWaygood
approved these changes
Jul 19, 2026
Member
|
thanks! |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
math.logis a C function that takes no keyword arguments. At runtime both keyword forms fail:But the stub omits the trailing
/, so type checkers currently acceptmath.log(x=8)/math.log(8, base=2)— code that type-checks clean yet crashes at runtime.Every sibling in the same module is already positional-only —
isqrt,ldexp,lgamma,log10,log1p,log2,modfall end with, /— andcmath.logisdef log(z: _C, base: _C = ..., /) -> complex: ....math.logis the only one missing it.Add
, /(a positional-only parameter may still carry a default):