Add collections.deque.__rmul__#16055
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Jul 21, 2026
srittau
left a comment
srittau
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, but please remove the test case. For various reasons, we only use test cases for especially hard to type corner cases.
Declare `deque.__rmul__` so type checkers accept multiplication with an integer on the left. Refs: python#16034 Signed-off-by: Jason Scheffel <contact@jasonscheffel.com>
jason-scheffel
force-pushed
the
fix/deque-rmul
branch
from
July 21, 2026 13:01
ba6bf0a to
c3f2611
Compare
Contributor
Author
|
Removed the test case. |
This comment has been minimized.
This comment has been minimized.
srittau
approved these changes
Jul 21, 2026
Collaborator
|
CI failures are unrelated, but let's wait for #16060 to be merged to be safe. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16034.
Add
deque.__rmul__and a regression test for3 * deque([1, 2, 3]).Stubtest does not detect the missing method because
deque.__rmul__is aWrapperDescriptorType, and stubtest intentionally ignores missing stubentries for runtime wrapper descriptors with dunder names.