Skip to content

Fix pre-commit hook end-of-file-fixer interfering with CI. #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 2 commits into from
Jul 11, 2026
Merged

Fix pre-commit hook end-of-file-fixer interfering with CI. #2320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d71b574
1. excluded conformance/results/results.html from end-of-file-fixer (…
randolf-scholz Jul 11, 2026
c4a6c0f
instead of ingoring results.html in end-of-file fixer, tell jinja to …
randolf-scholz Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion conformance/results/results.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions conformance/src/reporting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def generate_summary(root_dir: Path):
env = jinja2.Environment(
loader=jinja2.FileSystemLoader(root_dir.joinpath("src/templates")),
autoescape=jinja2.select_autoescape(),
keep_trailing_newline=True,
)
env.filters["conformance_class"] = _conformance_class

Expand Down
1 change: 0 additions & 1 deletion conformance/tests/enums_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,3 @@ class Color12(Enum):
assert_type(Color12.RED, Literal[Color12.RED])
assert_type(Color12.GREEN, Literal[Color12.GREEN])
Color12.BLUE # E

1 change: 0 additions & 1 deletion conformance/tests/overloads_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,3 @@ def map(

def map(func: Any, iter1: Any, iter2: Any = ...) -> Any:
raise NotImplementedError

1 change: 0 additions & 1 deletion conformance/tests/overloads_consistency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,4 +115,3 @@ def decorated(x: str, /) -> str:
@_deco_2
def decorated(y: bytes, z: bytes) -> bytes:
return b""

2 changes: 1 addition & 1 deletion docs/spec/callables.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ a function within a type expression. The syntax is

Parameters specified using ``Callable`` are assumed to be positional-only.
The ``Callable`` form provides no way to specify keyword-only parameters,
or default argument values. For these use cases, see the section on
or default argument values. For these use cases, see the section on
`Callback protocols`_.

Meaning of ``...`` in ``Callable``
Expand Down