Skip to content

Fix native static attention sliding-window masks - #22285

Open
YIWENX14 wants to merge 1 commit into
pytorch:mainfrom
YIWENX14:export-D117411412
Open

Fix native static attention sliding-window masks#22285
YIWENX14 wants to merge 1 commit into
pytorch:mainfrom
YIWENX14:export-D117411412

Conversation

@YIWENX14

Copy link
Copy Markdown
Contributor

Summary:
The native static-attention mask kept every valid cache slot visible for every input row. For multi-token autoregressive chunks, row k therefore attended to too many cached tokens, and chunks longer than the local window also retained too many in-chunk keys. The QNN runner made the same assumption for long and sparse chunks.

Derive SMART_MASK cache visibility from ring age and each row's remaining window budget, bound the causal in-chunk region, and apply equivalent oldest-visible trimming in the QNN runner. Add regression coverage for cache wrapping, mixed local/global masks, and chunk lengths both above and below the sliding window. Update the SNR evaluator to use the public decode path so it exercises the same per-row masking behavior.

Differential Revision: D117411412

Summary:
The native static-attention mask kept every valid cache slot visible for every input row. For multi-token autoregressive chunks, row k therefore attended to too many cached tokens, and chunks longer than the local window also retained too many in-chunk keys. The QNN runner made the same assumption for long and sparse chunks.

Derive SMART_MASK cache visibility from ring age and each row's remaining window budget, bound the causal in-chunk region, and apply equivalent oldest-visible trimming in the QNN runner. Add regression coverage for cache wrapping, mixed local/global masks, and chunk lengths both above and below the sliding window. Update the SNR evaluator to use the public decode path so it exercises the same per-row masking behavior.

Differential Revision: D117411412
@pytorch-bot

pytorch-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22285

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 0181d8a with merge base d614f9d (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2026
@meta-codesync

meta-codesync Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@YIWENX14 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117411412.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant