Skip to content

Make MLX work when model is loaded on one thread and executed on another - #22294

Merged
metascroy merged 2 commits into
mainfrom
mlx-thread-affinity
Aug 31, 2026
Merged

Make MLX work when model is loaded on one thread and executed on another#22294
metascroy merged 2 commits into
mainfrom
mlx-thread-affinity

Conversation

@metascroy

Copy link
Copy Markdown
Contributor

No description provided.

@pytorch-bot

pytorch-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22294

Note: Links to docs will display an error until the docs builds have been completed.

❌ 20 Pending, 1 Unclassified Failure

As of commit 8849b81 with merge base ff50edd (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@digantdesai

Copy link
Copy Markdown
Contributor

CI is not happy :P

Comment thread backends/mlx/runtime/MLXBackend.cpp
@metascroy

Copy link
Copy Markdown
Contributor Author

CI is not happy :P

trunk is not happy :(

A PR changed delegate constant tagging last week, which requires corresponding mutable buffer change: #22296

@metascroy
metascroy merged commit b46bd04 into main Aug 31, 2026
252 of 254 checks passed
@metascroy
metascroy deleted the mlx-thread-affinity branch August 31, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mlx CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants