Conversation
louispt1
marked this pull request as ready for review
July 28, 2026 10:16
Member
Author
|
FYI @aaccensi - we should merge this once our sso changes are merged elsewhere |
aaccensi
reviewed
Aug 3, 2026
Comment on lines
+25
to
+26
| ["ETModel (ETLauncher local)", ENV.fetch("ETMODEL_CLIENT_ID"), ENV.fetch("ETMODEL_CLIENT_SECRET"), "http://etmodel.local.energytransitionmodel.com:3001/auth/identity/callback", version.model_url], | ||
| ["ETEngine (ETLauncher local)", ENV.fetch("ETENGINE_CLIENT_ID"), ENV.fetch("ETENGINE_CLIENT_SECRET"), "http://etengine.local.energytransitionmodel.com:3000/auth/identity/callback", version.engine_url], |
Member
There was a problem hiding this comment.
Not sure I understand this, aren't the callback and failure routes gone now in the identity_rails gem? Does this (and the comment above) still make sense?
Member
Author
There was a problem hiding this comment.
Good point, I think we can simplify this further
aaccensi
approved these changes
Aug 3, 2026
aaccensi
left a comment
aaccensi
left a comment
Member
There was a problem hiding this comment.
As far as I can see this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related- Goes with the other SSO: Login/Logout PRs:
identity rails
etengine
etmodel
myetm
collections
ETLauncher
Checklist