removes fathom - #78
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
💤 Files with no reviewable changes (6)
📝 WalkthroughWalkthroughAnalytics tracking migrates from fathom-client to Vercel's ChangesAnalytics Migration from Fathom to Vercel
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/components/CohortHero.tsxESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. src/lib/analytics.tsESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. src/providers/providers.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Actionable comments posted: 0 |
There was a problem hiding this comment.
Pull request overview
This PR removes the Fathom analytics integration and standardizes all event tracking on the existing Vercel Analytics wrapper (trackAnalyticsEvent / analyticsEvents), cleaning up legacy scripts and dependencies in the process.
Changes:
- Removed
fathom-clientfrom dependencies and deleted theFathomcomponent wiring from the app layout. - Replaced
trackEvent(...)calls withtrackAnalyticsEvent(...)and added consolidated event identifiers for cohort hero signup and the “witch” easter egg trigger. - Removed leftover/commented Fathom script references from static content.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/providers/providers.tsx | Switches “witch” easter egg tracking from Fathom to Vercel analytics events/properties. |
| src/lib/analytics.ts | Adds new consolidated event identifiers used by updated components. |
| src/components/JoinUs.tsx | Removes Fathom tracking call; relies on existing Vercel analytics tracking. |
| src/components/HireUs.tsx | Removes Fathom tracking calls; keeps Vercel analytics tracking for attempts/success/step completion. |
| src/components/Fathom.tsx | Deletes the Fathom client component entirely. |
| src/components/CohortHero.tsx | Replaces Fathom event with Vercel analytics event + properties. |
| src/app/layout.tsx | Removes <Fathom /> usage; keeps Vercel analytics component mounted. |
| public/witch/index.html | Removes commented Fathom script block. |
| package.json | Drops fathom-client dependency. |
| bun.lock | Updates lockfile to remove fathom-client (and includes lock metadata update). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* bandaid on the client submission form * feat: add Vercel Analytics integration (#76) * feat: add Vercel Analytics integration * fix: harden server analytics tracking * fix: classify consultation submission errors * feat: improve form error message handling (#77) * feat: improve form error message handling * fix: wire services field accessibility * docs: add PR review workflow documentation * removes fathom (#78) * adds homepage content and contact form (#80) * Update cohort join page to link to Portal join (#81) * CR #131: Update cohort join page to link to Portal join * CR #131: Update cohort join page to link to Portal join * CR #131: Remove dependency lockfile churn --------- Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> * Add Join navigation link on website root page (#83) * CR #133: Add Join navigation link on website root page * CR #133: Add Join navigation link on website root page * Revert "CR #133: Add Join navigation link on website root page" This reverts commit 5bc6eb0. --------- Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> * Ai solutions (#84) * adds ai solutions services * removes contact page * more add * Install Plausible analytics script (#86) Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> * Add Plausible hire funnel events (#89) Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> * Add plain-language context and layout refinements to home page Hero: plain-language framing for the mercenary tagline, "since 2019" linked to the Our Story section, dashes replaced with other punctuation throughout. Services: two-column layout (Arsenal of Expertise / Looking for AI Solutions) filling the full section width, matching the col-span-4/8/6 pattern used in MercenariesSection. AI heading now matches the main heading style. CTA button sized to 4 of 12 grid columns with spacing matching the MercenariesSection template. Background illustration moved to the left. Mercenaries / Portfolio / Hire Us / Testimonials: small eyebrow labels above each section heading for consistency. Case studies: DAOhaus description trimmed, em dash removed. Our Story: em dash replaced with a comma in the Join the Guild copy. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Rename flex-shrink-0 to shrink-0 in HireUsSection Tailwind CSS renamed several sizing utilities in v3.3 (flex-shrink-* -> shrink-*, flex-grow-* -> grow-*) and kept the old names only as deprecated aliases for backward compatibility. flex-shrink-0 still works today, but it's the legacy spelling — shrink-0 is the current, documented utility and is what new code in this repo should use going forward. This is a pure rename with no visual or behavioral change: shrink-0 compiles to the same shrink: 0 CSS declaration flex-shrink-0 did, applied to the Hire Us section's illustration image so it doesn't get squeezed by its flex siblings. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Sam Kuhlmann <samkuhlmann@gmail.com> Co-authored-by: ECWireless <40322776+ECWireless@users.noreply.github.com> Co-authored-by: Queen Raida <raidguildbot@gmail.com> Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* bandaid on the client submission form * feat: add Vercel Analytics integration (#76) * feat: add Vercel Analytics integration * fix: harden server analytics tracking * fix: classify consultation submission errors * feat: improve form error message handling (#77) * feat: improve form error message handling * fix: wire services field accessibility * docs: add PR review workflow documentation * removes fathom (#78) * adds homepage content and contact form (#80) * Update cohort join page to link to Portal join (#81) * CR #131: Update cohort join page to link to Portal join * CR #131: Update cohort join page to link to Portal join * CR #131: Remove dependency lockfile churn --------- Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> * Add Join navigation link on website root page (#83) * CR #133: Add Join navigation link on website root page * CR #133: Add Join navigation link on website root page * Revert "CR #133: Add Join navigation link on website root page" This reverts commit 5bc6eb0. --------- Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> * Ai solutions (#84) * adds ai solutions services * removes contact page * more add * Install Plausible analytics script (#86) Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> * Add Plausible hire funnel events (#89) Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> --------- Co-authored-by: Sam Kuhlmann <samkuhlmann@gmail.com> Co-authored-by: ECWireless <40322776+ECWireless@users.noreply.github.com> Co-authored-by: Queen Raida <raidguildbot@gmail.com> Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com>
* Fix Portfolio background image aspect-ratio warning (#92) * Fix aspect-ratio warning and add priority to Portfolio background image Tailwind's preflight forces height:auto on every <img>, which conflicted with the explicit height prop and triggered Next.js's "either width or height modified" warning. Fixed with an explicit inline style matching both dimensions (wins over preflight via specificity). Also set priority since Next flagged this image as the page's LCP candidate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Add mobile label spacing, clean up deprecated/redundant Tailwind classes - ServicesSection/PortfolioSection: 40px top margin on the section eyebrow labels on mobile only (mt-10 md:mt-0), matching Tailwind's default spacing scale rather than an arbitrary value. - PortfolioSection: flex-grow -> grow, flex-shrink-0 -> shrink-0 (deprecated Tailwind names; confirmed identical compiled CSS). - PortfolioSection: removed [&]:!hidden, [&]:lg:!block, [&]:!grid -- redundant duplicates of hidden, lg:block, and grid respectively (confirmed via compiled CSS output, same computed values). Kept the one non-redundant class, converting [&]:lg:!hidden to its plain equivalent lg:hidden since nothing else needs the !important override. Verified the desktop-carousel/mobile-grid toggle still switches correctly at the lg breakpoint via computed style checks at 375px/800px/1400px. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Fix mobile regression: Portfolio background image height was hard-coded The previous fix set style={{ width: "632px", height: "843px" }} to resolve the aspect-ratio console warning. Tailwind's preflight max-width:100% still correctly shrinks the width on narrow viewports, but a hard-coded height has no equivalent responsive cap. On mobile the image rendered 390px wide but stayed a fixed 843px tall instead of scaling to ~520px, pushing the "Completed Quests" text below it into an overlap. Changed height back to "auto" so it scales proportionally with whatever width actually renders, matching production's original behavior. Width stays an explicit pixel value, satisfying Next's "both width and height must be modified together" check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> * Update hero copy: "is the OG decentralized collective" (#93) Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> * Deploy (#87) * bandaid on the client submission form * feat: add Vercel Analytics integration (#76) * feat: add Vercel Analytics integration * fix: harden server analytics tracking * fix: classify consultation submission errors * feat: improve form error message handling (#77) * feat: improve form error message handling * fix: wire services field accessibility * docs: add PR review workflow documentation * removes fathom (#78) * adds homepage content and contact form (#80) * Update cohort join page to link to Portal join (#81) * CR #131: Update cohort join page to link to Portal join * CR #131: Update cohort join page to link to Portal join * CR #131: Remove dependency lockfile churn --------- Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> * Add Join navigation link on website root page (#83) * CR #133: Add Join navigation link on website root page * CR #133: Add Join navigation link on website root page * Revert "CR #133: Add Join navigation link on website root page" This reverts commit 5bc6eb0. --------- Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> * Ai solutions (#84) * adds ai solutions services * removes contact page * more add * Install Plausible analytics script (#86) Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> * Add Plausible hire funnel events (#89) Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> --------- Co-authored-by: Sam Kuhlmann <samkuhlmann@gmail.com> Co-authored-by: ECWireless <40322776+ECWireless@users.noreply.github.com> Co-authored-by: Queen Raida <raidguildbot@gmail.com> Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com> --------- Co-authored-by: Suede <101133311+Suede0619@users.noreply.github.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: Dekan <dekanbro@gmail.com> Co-authored-by: ECWireless <40322776+ECWireless@users.noreply.github.com> Co-authored-by: Queen Raida <raidguildbot@gmail.com> Co-authored-by: Prism Codex <prism-codex@users.noreply.github.com>
Summary by CodeRabbit