fix(android): reject invalid manifest XML before parsing - #2844
Open
OskarEichler wants to merge 2 commits into
Open
fix(android): reject invalid manifest XML before parsing#2844OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This was referenced Aug 28, 2026
OskarEichler
marked this pull request as ready for review
August 30, 2026 09:46
Author
|
Resolved the draft blocker: I removed the stray unmatched |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XMLValidator.validate()returns eithertrueor an error object. The previous truthiness check accepted the error object, so malformed manifests could be parsed as if validation succeeded. Require an actualtrueresult.The existing multi-activity fixture also contained an unmatched
</queries>tag. This PR corrects that fixture and adds a dedicated malformed-manifest regression.Compatibility
Malformed manifests now return
nullinstead of occasionally yielding a launcher from partially parsed XML. Valid manifests retain their existing behavior. No dependency or SDK version changes.Verification
yarn buildyarn test packages/cli-config-android/src/config/__tests__/getMainActivity.test.ts --runInBand(6 tests passed)git diff --checkType: fix