Skip to content

fix(ios): prevent missing hairlineWidth border strokes at subpixel Y … #58162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shashikant-panchal wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −8
Open

fix(ios): prevent missing hairlineWidth border strokes at subpixel Y … #58162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,9 @@ static void RCTAddContourEffectToLayer(
UIEdgeInsets imageCapInsets = image.capInsets;
CGRect contentsCenter = CGRect{
CGPoint{imageCapInsets.left / imageSize.width, imageCapInsets.top / imageSize.height},
CGSize{(CGFloat)1.0 / imageSize.width, (CGFloat)1.0 / imageSize.height}};
CGSize{
MAX(0, (imageSize.width - imageCapInsets.left - imageCapInsets.right) / imageSize.width),
MAX(0, (imageSize.height - imageCapInsets.top - imageCapInsets.bottom) / imageSize.height)}};
layer.contents = (id)image.CGImage;
layer.contentsScale = image.scale;

Expand Down
8 changes: 2 additions & 6 deletions packages/react-native/React/Views/RCTBorderDrawing.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,8 @@ static CGPathRef RCTPathCreateOuterOutline(BOOL drawToEdge, CGRect rect, RCTCorn

const CGSize size = makeStretchable ? (CGSize){
// 1pt for the middle stretchable area along each axis
// we also need to round the edge insets to avoid border bleeding
// this is because if the size is decimal, when calculating the unit
// rectangle for CALayer.contentsCenter we encounter rounding errors
// which causes visual glitches
ceil(edgeInsets.left) + 1 + ceil(edgeInsets.right),
ceil(edgeInsets.top) + 1 + ceil(edgeInsets.bottom),
edgeInsets.left + 1 + edgeInsets.right,
edgeInsets.top + 1 + edgeInsets.bottom,
} : viewSize;

UIGraphicsImageRenderer *const imageRenderer =
Expand Down
5 changes: 4 additions & 1 deletion packages/react-native/React/Views/RCTView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,10 @@ - (void)displayLayer:(CALayer *)layer
CGSize size = image.size;
UIEdgeInsets insets = image.capInsets;
CGRectMake(
insets.left / size.width, insets.top / size.height, (CGFloat)1.0 / size.width, (CGFloat)1.0 / size.height);
insets.left / size.width,
insets.top / size.height,
MAX(0, (size.width - insets.left - insets.right) / size.width),
MAX(0, (size.height - insets.top - insets.bottom) / size.height));
});

layer.contents = (id)image.CGImage;
Expand Down
Loading