Skip to content

Cover react/runtime with Stable API guards #58167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cover react/runtime with Stable API guards #58167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/BindingsInstaller.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/runtime/ReactInstance.h>

namespace facebook::react {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/BridgelessNativeMethodCallInvoker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <ReactCommon/CallInvoker.h>
#include <cxxreact/MessageQueueThread.h>
#include <memory>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/BufferedRuntimeExecutor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <ReactCommon/RuntimeExecutor.h>
#include <jsi/jsi.h>
#include <atomic>
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/runtime/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ target_link_libraries(
jsi
jsitooling
jsireact
react_cxxstableapi
react_utils
jsinspector
react_featureflags
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/PlatformTimerRegistry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <cstdint>
#include <memory>

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/ReactInstance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <ReactCommon/RuntimeExecutor.h>
#include <cxxreact/JSBigString.h>
#include <cxxreact/MessageQueueThread.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/TimerManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#include <ReactCommon/RuntimeExecutor.h>
#include <unordered_map>
#include <vector>
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/React-RuntimeApple.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Pod::Spec.new do |s|
s.dependency "React-jserrorhandler"
s.dependency "React-jsinspector"
s.dependency "React-featureflags"
s.dependency "React-cxxstableapi"
add_dependency(s, "React-jsitooling", :framework_name => "JSITooling")
add_dependency(s, "React-RCTFBReactNativeSpec")
add_dependency(s, "React-utils", :additional_framework_paths => ["react/utils/platform/ios"])
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/ObjCTimerRegistry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <UIKit/UIKit.h>

#import <React/RCTTiming.h>
Expand Down
2 changes: 2 additions & 0 deletions ...t-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTContextContainerHandling.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <Foundation/Foundation.h>

#import <react/utils/ContextContainer.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <hermes/Public/CrashManager.h>
#import <jsi/jsi.h>
#import <react/runtime/JSRuntimeFactory.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHost+Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import "RCTHost.h"

#import "RCTContextContainerHandling.h"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHost.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <Foundation/Foundation.h>

#import <React/RCTDefines.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <UIKit/UIKit.h>

#import <React/RCTDefines.h>
Expand Down
2 changes: 2 additions & 0 deletions ...ages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTJSThreadManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <Foundation/Foundation.h>

#import <React/RCTMessageThread.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTJscInstance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <cxxreact/MessageQueueThread.h>
#import <jsi/jsi.h>
#import <react/runtime/JSRuntimeFactory.h>
Expand Down
2 changes: 2 additions & 0 deletions .../ReactCommon/react/runtime/platform/ios/ReactCommon/RCTLegacyUIManagerConstantsProvider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>

#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP

#include <jsi/jsi.h>
Expand Down
2 changes: 2 additions & 0 deletions ...act-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTPerformanceLoggerUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <Foundation/Foundation.h>

@class RCTPerformanceLogger;
Expand Down
Loading