Skip to content

Fix intermittent CoreServices XPC crash in RCTBlobManager blob name derivation #58172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1337mus wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Fix intermittent CoreServices XPC crash in RCTBlobManager blob name derivation #58172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/react-native/Libraries/Blob/RCTBlobManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,11 +297,16 @@ - (id)handleNetworkingResponse:(NSURLResponse *)response data:(NSData *)data
// An empty body will have nil for data, in this case we need to return
// an empty blob as per the XMLHttpRequest spec.
data = data ?: [NSData new];
// -[NSURLResponse suggestedFilename] resolves the filename through a
// CoreServices/UTType XPC lookup that can crash intermittently
// (NSXPCEncoder) when called off the main thread. Since whatwg-fetch reads
// every response as a blob, that lookup used to run for every network
// response. Derive the name from the URL instead; no XPC round-trip.
return @{
@"blobId" : [self store:data],
@"offset" : @0,
@"size" : @(data.length),
@"name" : RCTNullIfNil([response suggestedFilename]),
@"name" : RCTNullIfNil(response.URL.lastPathComponent),
@"type" : RCTNullIfNil([response MIMEType]),
};
}
Expand Down
Loading