Pass accessibilityLabelledBy through Button and Touchable - #58173
Pass accessibilityLabelledBy through Button and Touchable#58173angelabenavente wants to merge 3 commits into
Conversation
|
Hi @angelabenavente! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@christophpurrer has imported this pull request. If you are a Meta employee, you can view this in D117876255. |
Summary:
Viewalready mapsaccessibilityLabelledBy/aria-labelledby.Buttondoes not extendAccessibilityPropsand does not spread leftover props, so those values were dropped.Forwarding them only from
Buttonis not enough.TouchableNativeFeedbackandTouchableOpacitycopy a fixed accessibility list onto the host view;accessibilityHintis on that list, labelledBy was not. This change forwards labelledBy the same way so it reaches the native view.Changelog:
[GENERAL] [ADDED] - Pass accessibilityLabelledBy and aria-labelledby through Button and Touchable
Test Plan:
Fantom: 12 tests passing, including the native
accessibilityLabelledByprop and thearia-labelledbyalias:yarn fantom 'Libraries/Components/__tests__/Button-itest'Result: