Skip to content

Pass accessibilityLabelledBy through Button and Touchable - #58173

Open
angelabenavente wants to merge 3 commits into
react:mainfrom
angelabenavente:feat-button-a11y-forward
Open

Pass accessibilityLabelledBy through Button and Touchable#58173
angelabenavente wants to merge 3 commits into
react:mainfrom
angelabenavente:feat-button-a11y-forward

Conversation

@angelabenavente

Copy link
Copy Markdown

Summary:

View already maps accessibilityLabelledBy / aria-labelledby. Button does not extend AccessibilityProps and does not spread leftover props, so those values were dropped.

Forwarding them only from Button is not enough. TouchableNativeFeedback and TouchableOpacity copy a fixed accessibility list onto the host view; accessibilityHint is on that list, labelledBy was not. This change forwards labelledBy the same way so it reaches the native view.

Changelog:

[GENERAL] [ADDED] - Pass accessibilityLabelledBy and aria-labelledby through Button and Touchable

Test Plan:

Fantom: 12 tests passing, including the native accessibilityLabelledBy prop and the aria-labelledby alias:

yarn fantom 'Libraries/Components/__tests__/Button-itest'

Result:

Captura de pantalla 2026-08-27 a las 20 56 38

@meta-cla

meta-cla Bot commented Aug 27, 2026

Copy link
Copy Markdown

Hi @angelabenavente!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2026
@meta-cla

meta-cla Bot commented Aug 27, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 27, 2026
@meta-codesync

meta-codesync Bot commented Aug 28, 2026

Copy link
Copy Markdown

@christophpurrer has imported this pull request. If you are a Meta employee, you can view this in D117876255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant