Cover react/renderer/animations with guards - #58185
Open
j-piasecki wants to merge 1 commit into
Open
Conversation
Summary: Classifies `react/renderer/animations:animations` as a "for frameworks" target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/FrameworksGuard.h>` to the module's six exported headers (`LayoutAnimationCallbackWrapper.h`, `LayoutAnimationDriver.h`, `LayoutAnimationKeyFrameManager.h`, `conversions.h`, `primitives.h`, `utils.h`), and wires the guard dependency into BUCK and CMake. No CocoaPods change is needed: the module ships as a subspec of `React-Fabric`, whose parent spec already declares `React-cxxstableapi` and calls `mark_as_react_native_build`. Consumers that opt into `RN_STRICT_API` now get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D117863703
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117863703. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/renderer/animations:animationsas a "for frameworks" target under the C++ stable API three-tier visibility model. Adds#include <react/cxxstableapi/FrameworksGuard.h>to the module's six exported headers (LayoutAnimationCallbackWrapper.h,LayoutAnimationDriver.h,LayoutAnimationKeyFrameManager.h,conversions.h,primitives.h,utils.h), and wires the guard dependency into BUCK and CMake. No CocoaPods change is needed: the module ships as a subspec ofReact-Fabric, whose parent spec already declaresReact-cxxstableapiand callsmark_as_react_native_build.Consumers that opt into
RN_STRICT_APInow get a warning if they include these headers directly, which they can acknowledge withRN_ALLOW_FRAMEWORKS; without that flag the guards are inert, so no existing build changes behaviour.Changelog: [Internal]
Differential Revision: D117863703