Skip to content

Stop using paperComponentName in React Native core component specs #58188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophpurrer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop using paperComponentName in React Native core component specs #58188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...-native/Libraries/LogBox/__tests__/__snapshots__/LogBoxNotificationContainer-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`LogBoxNotificationContainer should render both an error and warning notification 1`] = `
<RCTSafeAreaView
<SafeAreaView
style={
Object {
"bottom": 20,
Expand Down Expand Up @@ -101,7 +101,7 @@ exports[`LogBoxNotificationContainer should render both an error and warning not
totalLogCount={1}
/>
</View>
</RCTSafeAreaView>
</SafeAreaView>
`;

exports[`LogBoxNotificationContainer should render null with no logs 1`] = `null`;
Expand All @@ -113,7 +113,7 @@ exports[`LogBoxNotificationContainer should render selected fatal error even whe
exports[`LogBoxNotificationContainer should render selected syntax error even when disabled 1`] = `null`;

exports[`LogBoxNotificationContainer should render the latest error notification 1`] = `
<RCTSafeAreaView
<SafeAreaView
style={
Object {
"bottom": 20,
Expand Down Expand Up @@ -168,11 +168,11 @@ exports[`LogBoxNotificationContainer should render the latest error notification
totalLogCount={2}
/>
</View>
</RCTSafeAreaView>
</SafeAreaView>
`;

exports[`LogBoxNotificationContainer should render the latest warning notification 1`] = `
<RCTSafeAreaView
<SafeAreaView
style={
Object {
"bottom": 20,
Expand Down Expand Up @@ -227,5 +227,5 @@ exports[`LogBoxNotificationContainer should render the latest warning notificati
totalLogCount={2}
/>
</View>
</RCTSafeAreaView>
</SafeAreaView>
`;
3 changes: 0 additions & 3 deletions ...ve/src/private/components/activityindicator/specs/ActivityIndicatorViewNativeComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,4 @@ type RCTActivityIndicatorViewNativeProps = Readonly<{

export default codegenNativeComponent<RCTActivityIndicatorViewNativeProps>(
'ActivityIndicatorView',
{
paperComponentName: 'RCTActivityIndicatorView',
},
) as HostComponent<RCTActivityIndicatorViewNativeProps>;
1 change: 0 additions & 1 deletion packages/react-native/src/private/components/modal/specs/RCTModalHostViewNativeComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,5 @@ export default codegenNativeComponent<RCTModalHostViewNativeProps>(
'ModalHostView',
{
interfaceOnly: true,
paperComponentName: 'RCTModalHostView',
},
) as HostComponent<RCTModalHostViewNativeProps>;
1 change: 0 additions & 1 deletion ...ct-native/src/private/components/refreshcontrol/specs/PullToRefreshViewNativeComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export const Commands: NativeCommands = codegenNativeCommands<NativeCommands>({
export default codegenNativeComponent<PullToRefreshNativeProps>(
'PullToRefreshView',
{
paperComponentName: 'RCTRefreshControl',
excludedPlatforms: ['android'],
},
) as HostComponent<PullToRefreshNativeProps>;
1 change: 0 additions & 1 deletion .../react-native/src/private/components/safeareaview/specs/RCTSafeAreaViewNativeComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ type RCTSafeAreaViewNativeProps = Readonly<{
export default codegenNativeComponent<RCTSafeAreaViewNativeProps>(
'SafeAreaView',
{
paperComponentName: 'RCTSafeAreaView',
interfaceOnly: true,
},
) as HostComponent<RCTSafeAreaViewNativeProps>;
1 change: 0 additions & 1 deletion packages/react-native/src/private/components/switch/specs/SwitchNativeComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export const Commands: NativeCommands = codegenNativeCommands<NativeCommands>({
});

export default codegenNativeComponent<SwitchNativeProps>('Switch', {
paperComponentName: 'RCTSwitch',
excludedPlatforms: ['android'],
interfaceOnly: true,
}) as ComponentType;
Loading