Improve rule definitions#706
Open
simonschaufi wants to merge 1 commit into
Open
Conversation
simonschaufi
commented
Jul 10, 2026
simonschaufi
commented
- Use active voice
- Remove final fullstop
- Use code style
- Use active voice - Remove final fullstop - Use code style
| public function getRuleDefinition(): RuleDefinition | ||
| { | ||
| return new RuleDefinition('Change Requires annotations with values to attributes', [ | ||
| return new RuleDefinition('Change requires annotations with values to attributes', [ |
Member
There was a problem hiding this comment.
Wrong line on phone. I meant this one.
This changes "requires" keyword to word, a
@requiresmight be better
| public function getRuleDefinition(): RuleDefinition | ||
| { | ||
| return new RuleDefinition('Refactor deprecated withConsecutive() to willReturnCallback() structure', [ | ||
| return new RuleDefinition('Refactor deprecated `withConsecutive()` to `willReturnCallback()` structure', [ |
Member
There was a problem hiding this comment.
Can you do typos first and leave this function names wrap for next round? I find it hard to review and not sure about this change.
Author
There was a problem hiding this comment.
Hmm, that will also make it hatte for me and create a lot of extra time to split into another PR. These changes already took me a lot of time and now I need to go through all rules again? I did these kind of changes already before and they went through without causing much trouble in another repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.