Skip to content

fix(npm): allow rename when replacement value is unchanged#44486

Open
straub wants to merge 1 commit into
renovatebot:mainfrom
straub:fix/replacement-rename-when-version-unchanged
Open

fix(npm): allow rename when replacement value is unchanged#44486
straub wants to merge 1 commit into
renovatebot:mainfrom
straub:fix/replacement-rename-when-version-unchanged

Conversation

@straub

@straub straub commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Changes

This change adds an additional condition so that replacement updates can proceed if the name changes but the version value does not.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

Discussion: #44426

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

@github-actions github-actions Bot requested a review from viceice July 10, 2026 21:41

it('replaces when version is not changing', () => {
const upgrade = {
depType: 'peerDependencies',

@straub straub Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My brain's still anchored to peer deps, where I encountered this issue. I can generalize this to dependencies, if you all prefer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants