fix: wrap binary path resolution with fileURLToPath#1177
Conversation
|
I tested this out on Windows and the extension now works. |
|
Thanks for the fix! I had the same problem. But in my case it seems to be pathToFileURL, not fileURLToPath, that solves the problem. The issue persists with fileURLToPath. |
Yeah, I agree. Looking back at the forum thread, my guess is that https://forum.rescript-lang.org/t/help-vscode-tooling-is-broken-for-me-on-windows/7112 There was a lot of trial and error during the investigation, so I'm not sure the whole code path was ever verified with logging. It's also possible that once a That said, I think the idea was right. The path does need to be converted to a file URL. |
The extension was failing to correctly resolve the path on Windows.
Adding fileURLToPath uses node's built in way to normalize the file URL so it works across platforms.