Move new pilot functions into a compatibility layer so we don't need immediate pro release#1325
Merged
Merged
Conversation
…immediate pro release In #1317 we added some new functions to the pilot to make the active job rescue system work. I was thinking this morning that the way this was done is a little suboptimal for our pro customers. Expanding the pilot interface makes the pro pilot immediately incompatible, so once we released this we'd need to make sure to do an _immediate_ fast follow with a pro release, otherwise there'd be no compatible version. And even with that fast follow, if a customer tried to upgrade just River by itself, it'd break their pro version without an upgrade. Here, move the new functions into a special `PilotJobRescuer` interface that's used where available by the rescuer, but allows a fall back in case it's not. This will let us release the pro side at our leisure and there will be multiple compatible River releases by then. We'd want to unwind this eventually, so I left a couple comments in place with instructions on how to do that.
Contributor
Author
|
@bgentry Thoughts on this? Seems kind of nice as we won't have to rush as badly to get a Pro PR out. |
Contributor
Author
|
Excellent. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1317 we added some new functions to the pilot to make the active job
rescue system work.
I was thinking this morning that the way this was done is a little
suboptimal for our pro customers. Expanding the pilot interface makes
the pro pilot immediately incompatible, so once we released this we'd
need to make sure to do an immediate fast follow with a pro release,
otherwise there'd be no compatible version. And even with that fast
follow, if a customer tried to upgrade just River by itself, it'd break
their pro version without an upgrade.
Here, move the new functions into a special
PilotJobRescuerinterfacethat's used where available by the rescuer, but allows a fall back in
case it's not. This will let us release the pro side at our leisure and
there will be multiple compatible River releases by then.
We'd want to unwind this eventually, so I left a couple comments in
place with instructions on how to do that.