media: rockchip: isp: fix v3x lsc tasklet disable imbalanceRemove tasklet_disable call in rkisp_init_params_vdev - #389
Open
Mv-mua wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v3x LSC tasklet is disabled at probe and never re-enabled
afterwards. Whenever LSC is configured on a single ISP while LSC
is enabled, isp_lsc_config()/isp_lsc_enable() schedule this still
disabled tasklet, and tasklet_action_common() finds count != 0, so
it re-queues the tasklet and re-raises TASKLET_SOFTIRQ forever,
spinning the CPU in ksoftirqd (~6.5M TASKLET/s observed on RK3588).
Remove the unbalanced tasklet_disable() so the tasklet is always
runnable when scheduled, matching the isp_params_v32.c implementation
which never disables its lsc_tasklet.
Signed-off-by: Mv-mua 2658233603@qq.com