Add specs for Kernel#p return values - #1385
Merged
andrykonchin merged 1 commit intoJul 27, 2026
Merged
Conversation
Kernel#p's return value had no coverage for 3 scenarios: - nil for no arguments - the argument itself (not a 1-element Array) for a single argument - a new Array for multiple arguments That passthrough is what lets `p` be used inline where `puts` cannot, since `puts` always returns nil. The nil cases are asserted on the existing "prints nothing" examples, as `core/io/puts_spec.rb` does for IO#puts. The passthrough cases get their own examples, as `core/io/output_spec.rb` does for IO#<<. Specs are under Kernel#p only, following a1f57e8. Matchers follow ruby#1350 (.should == nil, .should.equal?).
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋🏾
Found this implementing
Kernel#pfor garnet-js. The three-branch return had to be derived from MRI by hand since nothing in the suite pins it.🔧
Kernel#p's return value had no coverage for 3 scenarios:That passthrough is what lets
pbe used inline whereputscannot, sinceputsalways returns nil. An implementation that simply returned the collected arguments would pass every existing example while returning[]for no arguments and[x]for one.The nil cases are asserted on the existing "prints nothing" examples, as
core/io/puts_spec.rbdoes forIO#puts. The passthrough cases get their own examples, ascore/io/output_spec.rbdoes for IO#<<. Specs are underKernel#ponly, following a1f57e8.Matchers follow #1350 (
.should == nil,.should.equal?).