Skip to content

Preserve nil values in array-valued form fields #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Preserve nil values in array-valued form fields #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cdc497
Preserve nil values in array-valued form fields
OskarEichler Aug 27, 2026
79e8090
test: cover URI regression
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/uri/common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,7 @@ def self.encode_www_form(enum, enc=nil)
str << '='
str << encode_www_form_component(w, enc)
end
str
end.join('&')
else
str = encode_www_form_component(k, enc)
Expand Down
5 changes: 5 additions & 0 deletions test/uri/test_common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ class Foo
end
end


def test_encode_www_form_preserves_nil_array_values
assert_equal("foo&foo=a&foo", URI.encode_www_form(foo: [nil, "a", nil]))
end

def test_fallback_constants
EnvUtil.suppress_warning do
assert_raise(NameError) { URI::FOO }
Expand Down