Skip to content

Preserve caller options when constructing an RFC2396 parser #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −1
Open

Preserve caller options when constructing an RFC2396 parser #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb09a80
Preserve caller options when constructing an RFC2396 parser
OskarEichler Aug 27, 2026
f3fca13
test: cover URI regression
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/uri/rfc2396_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class RFC2396_Parser
# u1.eql?(u2) #=> false
#
def initialize(opts = {})
@pattern = initialize_pattern(opts)
@pattern = initialize_pattern(opts.transform_values(&:dup))
@pattern.each_value(&:freeze)
@pattern.freeze

Expand Down
13 changes: 13 additions & 0 deletions test/uri/test_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,19 @@ def uri_to_ary(uri)
uri.class.component.collect {|c| uri.send(c)}
end


def test_rfc2396_parser_preserves_options
escaped = "%[0-9a-fA-F]{2}"
options = {ESCAPED: escaped}

parser = URI::RFC2396_Parser.new(options)

assert_equal({ESCAPED: escaped}, options)
assert_equal(false, escaped.frozen?)
assert_equal("http://example.test/a%20b", parser.parse("http://example.test/a%20b").to_s)
assert_nothing_raised { URI::RFC2396_Parser.new(options.freeze) }
end

def test_inspect
assert_match(/URI::RFC2396_Parser/, URI::RFC2396_Parser.new.inspect)
assert_match(/URI::RFC3986_Parser/, URI::Parser.new.inspect)
Expand Down