Add missing avx512vl intrinsics for f32->u32 conversions - #2197
Open
Shnatsel wants to merge 1 commit into
Open
Conversation
Collaborator
|
r? @sayantn rustbot has assigned @sayantn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust#158196
Adds 6 intrinsics that were apparently forgotten by Intel and not included into the Intrinsics Guide web viewer, despite being present in the Intel Software Development Manual and implemented in clang. They all lower into a single hardware instruction and there is no other way to access that instruction; the AVX2 emulation is very costly compared to these native conversions.
The implementation mirrors both the existing 512-bit-wide form and the clang implementation for these 128-bit and 256-bit forms.
This is my first contribution so I have no idea what I'm doing. I don't know what the stabilization process for these would be and if these are supposed to be instantly stable or not, so I just made up a new unstable feature name.