fix(release): allow timestamp.apple.com:80 in egress allowlist - #134
Merged
Conversation
quill fetches an RFC3161 timestamp from Apple's TSA over plain HTTP while signing; the third v0.5.3 run failed there. Timestamp tokens are themselves signed, so HTTP is safe for this endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third v0.5.3 attempt got into actual signing and hit the last missing endpoint: quill requests an RFC3161 timestamp from
http://timestamp.apple.com/ts01(plain HTTP — the tokens are signed, this is how Apple's TSA works). The rest of the sign/notarize/publish flow is already allowlisted (appstoreconnect, notary S3 wildcards, uploads.github.com).