refactor: move gate-check to consuming repos - #179
Open
madhur310 wants to merge 1 commit into
Open
Conversation
Prevent inversion of control by having consuming repos implement gate-check before calling shared promote workflow. Changes: - Add vscode-find-nightly-candidate.yml (reusable workflow to find nightlies) - Simplify vscode-promote-prerelease.yml (publishing-only): - Remove find-nightly-candidate job (callers use vscode-find-nightly-candidate.yml) - Remove quality-gate job (callers use check-ci-status action inline) - Remove min-tag-age-days and required-ci-checks inputs - Make release-tag required (callers provide it) Pattern: Consuming repos now: 1. Call vscode-find-nightly-candidate.yml to find tag 2. Call check-ci-status action inline to validate CI (repo controls criteria) 3. Call vscode-promote-prerelease.yml to publish (publishing-only) Benefits: - Each repo controls its own promotion criteria - Shared workflows provide tools, not decisions - Gate-check visible in consuming repo's Actions UI Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent inversion of control by having consuming repos implement gate-check before calling shared promote workflow.
Changes:
Pattern: Consuming repos now:
Benefits: