Skip to content

refactor: move gate-check to consuming repos - #179

Open
madhur310 wants to merge 1 commit into
mainfrom
ms/caller-call-ci-status-check
Open

refactor: move gate-check to consuming repos#179
madhur310 wants to merge 1 commit into
mainfrom
ms/caller-call-ci-status-check

Conversation

@madhur310

Copy link
Copy Markdown
Contributor

Prevent inversion of control by having consuming repos implement gate-check before calling shared promote workflow.

Changes:

  • Add vscode-find-nightly-candidate.yml (reusable workflow to find nightlies)
  • Simplify vscode-promote-prerelease.yml (publishing-only):
    • Remove find-nightly-candidate job (callers use vscode-find-nightly-candidate.yml)
    • Remove quality-gate job (callers use check-ci-status action inline)
    • Remove min-tag-age-days and required-ci-checks inputs
    • Make release-tag required (callers provide it)

Pattern: Consuming repos now:

  1. Call vscode-find-nightly-candidate.yml to find tag
  2. Call check-ci-status action inline to validate CI (repo controls criteria)
  3. Call vscode-promote-prerelease.yml to publish (publishing-only)

Benefits:

  • Each repo controls its own promotion criteria
  • Shared workflows provide tools, not decisions
  • Gate-check visible in consuming repo's Actions UI

Prevent inversion of control by having consuming repos implement
gate-check before calling shared promote workflow.

Changes:
- Add vscode-find-nightly-candidate.yml (reusable workflow to find nightlies)
- Simplify vscode-promote-prerelease.yml (publishing-only):
  - Remove find-nightly-candidate job (callers use vscode-find-nightly-candidate.yml)
  - Remove quality-gate job (callers use check-ci-status action inline)
  - Remove min-tag-age-days and required-ci-checks inputs
  - Make release-tag required (callers provide it)

Pattern: Consuming repos now:
1. Call vscode-find-nightly-candidate.yml to find tag
2. Call check-ci-status action inline to validate CI (repo controls criteria)
3. Call vscode-promote-prerelease.yml to publish (publishing-only)

Benefits:
- Each repo controls its own promotion criteria
- Shared workflows provide tools, not decisions
- Gate-check visible in consuming repo's Actions UI

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@madhur310
madhur310 requested a review from peternhale August 26, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant