Skip to content

Fix Get NAM Models button mouse capture - #671

Merged
sdatkinson merged 1 commit into
mainfrom
634-get-models
Aug 9, 2026
Merged

Fix Get NAM Models button mouse capture#671
sdatkinson merged 1 commit into
mainfrom
634-get-models

Conversation

@sdatkinson

@sdatkinson sdatkinson commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • release the UI mouse capture before launching the external NAM models URL
  • prevent subsequent clicks from remaining routed to the Get NAM Models button after returning to a Windows DAW

Tests

  • git diff --check
  • clang-format --dry-run --Werror NeuralAmpModeler/NeuralAmpModelerControls.h
  • xcodebuild -project NeuralAmpModeler/projects/NeuralAmpModeler-macOS.xcodeproj -scheme macOS-APP -configuration Debug -derivedDataPath /tmp/nam-634-derived CODE_SIGNING_ALLOWED=NO build
  • Played around with it, seems to work as expected.

Resolves #634

@sdatkinson
sdatkinson merged commit 5bbe9f1 into main Aug 9, 2026
2 checks passed
@sdatkinson
sdatkinson deleted the 634-get-models branch August 9, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Get NAM models button in new VST3 plugin kinda broken

1 participant